feat: allow incoming and outgoing transfers #30
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -62,6 +67,14 @@ | |||
| gateway = GatewayEVM(gatewayAddress); | |||
| } | |||
|
|
|||
| function setAllowOutgoing(bool _allowOutgoing) external onlyOwner { | |||
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| allowOutgoing = _allowOutgoing; | ||
| } | ||
|
|
||
| function setAllowIncoming(bool _allowIncoming) external onlyOwner { |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Should be done through OZ pausing, instead. |
allowIncoming = falseon a chain prevents users from transferring NFTs to that chain. On ZetaChain it only reverts insideonCallwhen the destination is ZetaChain, because a universal contract on ZetaChain still needs to be able facilitate transfers between connected chains even when incoming to ZetaChain is disabled.allowOutgoing = falseon a chain prevents users from transferring NFTs from that chain.This can be implemented purely inside a universal NFT contract on ZetaChain, without owner having to toggle these params on different chains, but that comes at UX cost: if an outgoing transfer from chain A is disabled, it will still allow an outgoing transfer and will revert, which increases the risks.