Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check refund fee in omnichain interact task #150

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Jun 4, 2024

  • throw an error if the input amount is less than the refund fee. It's generally a good practice to send only amounts that can be refunded to prevent loss of funds.
  • renamed the optional argument from --token to --erc20 to be more explicit in what it represents
  • updated param and task descriptions

We cannot add withdraw fee check as not all universal apps use withdraw. This is something devs will add themselves.

@fadeev fadeev marked this pull request as ready for review June 4, 2024 15:04
@fadeev fadeev requested review from andresaiello, lucas-janon and a team as code owners June 4, 2024 15:04
Copy link
Collaborator

@GMaiolo GMaiolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fadeev fadeev merged commit 3443fd0 into main Jun 14, 2024
5 checks passed
@fadeev fadeev deleted the omnichain-interact-refund-fee branch June 14, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants