Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated faucet to v4 #66

Merged
merged 2 commits into from
Oct 12, 2023
Merged

feat: updated faucet to v4 #66

merged 2 commits into from
Oct 12, 2023

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Oct 4, 2023 •
edited
Loading

  • Updated faucet to v4
  • Removed flag for selecting chain (v4 only sends on ZetaChain)

@fadeev fadeev requested a review from GMaiolo October 4, 2023 08:56
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@zetachain/faucet-cli 4.0.1 filesystem +25 15.6 MB gmaiolozeta

GMaiolo
GMaiolo approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@GMaiolo GMaiolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@fadeev
Copy link
Member Author

fadeev commented Oct 12, 2023

@GMaiolo thanks!

@andresaiello I need a codeowner's approval.

@fadeev fadeev merged commit 6fb6087 into main Oct 12, 2023
6 checks passed
@fadeev fadeev deleted the faucet-4 branch October 12, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresaiello andresaiello andresaiello approved these changes

@GMaiolo GMaiolo GMaiolo approved these changes

@lucas-janon lucas-janon Awaiting requested review from lucas-janon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fadeev @GMaiolo @andresaiello