Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧱 Implementing the new design system #2111

Draft
wants to merge 210 commits into
base: main
Choose a base branch
from

Conversation

ziggabyte
Copy link
Contributor

@ziggabyte ziggabyte commented Aug 26, 2024

Description

This PR is the main to-do-list of the implementation of the new Zetkin design system, designed by @theo-organism .

Items that are links are ready to be worked on, click the link to get to the issue here on gitHub.

ziggabyte added 30 commits June 28, 2024 12:09
…in either menu items or component to popover.
@sefsh
Copy link

sefsh commented Nov 13, 2024

ZUIDivider

Current

image

Wanted

  • The middle variant should look like what the current fullWidth looks like.
  • The fullWidth should extend to the very edge of the card.

Two examples of divider at a truly full width:
image

image

@sefsh
Copy link

sefsh commented Nov 13, 2024

ZUIRadioGroup

Current

image image image image image image image

Wanted

  • margin-left removed for first item (top, bottom, start labelPlacement)
  • margin-right removed for last item (top, bottom, end labelPlacement)
  • margin-left doubled (2x) for non-first items (start labelPlacement)
  • add 8px margin-top, margin-bottom to item (top, bottom labelPlacement)
  • the error state that ZUICheckboxGroup, ZUISwitchGroup has
image image image image image image image

@sefsh
Copy link

sefsh commented Nov 13, 2024

ZUICheckbox

Current

image image image image image

Wanted

  • margin-left removed (top, bottom, start labelPlacement)
  • add 8px margin-top, margin-bottom to item (top, bottom labelPlacement)
  • margin-right removed (top, bottom, end labelPlacement)
  • disable text selection on label
image image image image image

@ziggabyte
Copy link
Contributor Author

ZUIDivider

* The `middle` variant should look like what the current `fullWidth` looks like.

* The `fullWidth` should extend to the very edge of the card.

This has to do with padding of the box that Storybook stories are rendered in. The fullWidth version of the ZUIDivider does go to the edge of the div that it is in, it's just that that div is inside of another div (by Storbook) that has some padding, which means it does not look like it goes "all the way". I can update the example to add a border around the div where the text and dividers are rendered, to make it more clear that they do go all the way to its closest parent.

@sefsh
Copy link

sefsh commented Nov 13, 2024

ZUICheckboxGroup

Wanted

  • remove margin-right
  • disable text selection on label

@sefsh
Copy link

sefsh commented Nov 13, 2024

ZUISwitch

Wanted

  • margin-left removed (top, bottom, start labelPlacement)
  • margin-right removed (top, bottom, start labelPlacement)
  • add 8px margin-top, margin-bottom to item (top, bottom labelPlacement)
  • disable text selection on label

@sefsh
Copy link

sefsh commented Nov 13, 2024

ZUISwitchGroup

Wanted

  • remove margin-right from label
  • disable text selection on label

@sefsh
Copy link

sefsh commented Nov 13, 2024

ZUIBadge

Current

Available colors
image

Wanted

  • "data colors", primary color should also be available
  • a smaller size should be available for non-numerical version (0.5 rem)
  • a 1px solid white border outside the dot for it to work as overlay on buttons etc.
image image image

@thepeno
Copy link
Collaborator

thepeno commented Nov 13, 2024

ZUIIcon

Wanted

  • Medium icon should be 24px width and height.
  • Large icon should be 35px width and height.

(These are default sizes from MUI)

@richardolsson
Copy link
Member

I just merged #2450 into main, which means that Storybook is now included in the automatic app dev/preview builds (e.g. https://app.dev.zetkin.org/storybook). This means that we can (soon) disable the separate storybook build.

This PR is so dependent on storybook builds, so I won't disable the separate builds until this PR has merged in main the next time. But after that, we can disable the storybook builds and just always use the /storybook link to access storybook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.