Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vector package optional #110

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

redeboer
Copy link
Collaborator

Seems that the vector package is an optional dependency:

phasespace/setup.cfg

Lines 52 to 53 in f6db1e0

vector =
vector >= 1.0.0

but it is still required for import phasespace:

import vector

What do you think about importing it only for type checking?

@redeboer redeboer added the enhancement New feature or request label Apr 23, 2024
@redeboer redeboer self-assigned this Apr 23, 2024
@jonas-eschle
Copy link
Contributor

jonas-eschle commented Apr 23, 2024

Um, yes, that's exactly how it was supposed to be in the first place, but it seemingly wasn't like this, thanks for catching! Must have overlooked something, or some pre-commit.

I'll just make a new release, patch fix

@jonas-eschle jonas-eschle enabled auto-merge (squash) April 23, 2024 15:13
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@f6db1e0). Click here to learn what that means.

Files Patch % Lines
phasespace/phasespace.py 46.15% 6 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage        ?   90.29%           
=======================================
  Files           ?        8           
  Lines           ?      515           
  Branches        ?       94           
=======================================
  Hits            ?      465           
  Misses          ?       34           
  Partials        ?       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-eschle jonas-eschle merged commit 7774693 into zfit:main Apr 23, 2024
6 checks passed
@redeboer redeboer deleted the optional-vector branch April 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants