Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep consistent for first #279

Merged
merged 4 commits into from
Nov 2, 2024
Merged

feat: keep consistent for first #279

merged 4 commits into from
Nov 2, 2024

Conversation

zh-lx
Copy link
Owner

@zh-lx zh-lx commented Nov 2, 2024

close #278

目前 first 在 pattern: 'first'type: 'all' 中表现不一致:

  • pattern: 'first' 中无论是否中文,都返回结果第一个字符
  • type: 'all': 是中文则返回结果第一个字符,非中文返回空字符串

修改为: 是中文则返回结果第一个字符,非中文返回非中文字符串

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f9ac8a6) to head (5179bc1).
Report is 10 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #279   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines        26174     26181    +7     
  Branches       503       504    +1     
=========================================
+ Hits         26174     26181    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zh-lx zh-lx merged commit fa07de9 into main Nov 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

first isn't consistent
2 participants