Skip to content

Commit

Permalink
Feat: Re-order checksums tab to be the last
Browse files Browse the repository at this point in the history 
Since it's the least used and most expensive to compute.
  • Loading branch information
@zhanghai
zhanghai committed Apr 17, 2024
1 parent 5c35f2d commit cdbd9b4
Show file tree
Hide file tree
Showing 4 changed files with 32 additions and 32 deletions.
18 changes: 9 additions & 9 deletions app/src/main/java/me/zhanghai/android/files/fileproperties/FilePropertiesDialogFragment.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,6 @@ class FilePropertiesDialogFragment : AppCompatDialogFragment() {
to { FilePropertiesPermissionTabFragment() }
)
}
if (FilePropertiesChecksumTabFragment.isAvailable(args.file)) {
add(
R.string.file_properties_checksum to {
FilePropertiesChecksumTabFragment().putArgs(
FilePropertiesChecksumTabFragment.Args(args.file.path)
)
}
)
}
if (FilePropertiesImageTabFragment.isAvailable(args.file)) {
add(
R.string.file_properties_image to {
Expand Down Expand Up @@ -119,6 +110,15 @@ class FilePropertiesDialogFragment : AppCompatDialogFragment() {
}
)
}
if (FilePropertiesChecksumTabFragment.isAvailable(args.file)) {
add(
R.string.file_properties_checksum to {
FilePropertiesChecksumTabFragment().putArgs(
FilePropertiesChecksumTabFragment.Args(args.file.path)
)
}
)
}
}
.map { getString(it.first) to it.second }
.toTypedArray()
Expand Down
12 changes: 6 additions & 6 deletions app/src/main/res/values-zh-rCN/strings.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -340,12 +340,6 @@
<string name="file_properties_permission_set_selinux_context_title">更改 SELinux 上下文</string>
<string name="file_properties_permission_set_selinux_context_restore">还原</string>
<string name="file_properties_permission_recursive">应用到包含的文件</string>
<string name="file_properties_checksum">校验和</string>
<string name="file_properties_checksum_compare">比较</string>
<string name="file_properties_checksum_compare_placeholder">任意校验和</string>
<string name="file_properties_checksum_compare_match_format">与 %1$s 校验和匹配</string>
<string name="file_properties_checksum_compare_prefix_match_format">与 %1$s 校验和的前缀匹配</string>
<string name="file_properties_checksum_compare_no_match">未找到匹配的校验和</string>
<string name="file_properties_image">图片</string>
<string name="file_properties_media_dimensions">尺寸</string>
<string name="file_properties_media_dimensions_format">%1$d \u00d7 %2$d</string>
Expand Down Expand Up @@ -399,6 +393,12 @@
<string name="file_properties_apk_signature_digests">签名</string>
<string name="file_properties_apk_signature_digests_empty">无有效签名</string>
<string name="file_properties_apk_past_signature_digests">旧签名</string>
<string name="file_properties_checksum">校验和</string>
<string name="file_properties_checksum_compare">比较</string>
<string name="file_properties_checksum_compare_placeholder">任意校验和</string>
<string name="file_properties_checksum_compare_match_format">与 %1$s 校验和匹配</string>
<string name="file_properties_checksum_compare_prefix_match_format">与 %1$s 校验和的前缀匹配</string>
<string name="file_properties_checksum_compare_no_match">未找到匹配的校验和</string>

<string name="storage_file_system_root_title">根目录</string>
<string name="storage_list_title">存储空间</string>
Expand Down
12 changes: 6 additions & 6 deletions app/src/main/res/values-zh-rTW/strings.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -340,12 +340,6 @@
<string name="file_properties_permission_set_selinux_context_title">變更 SELinux 上下文</string>
<string name="file_properties_permission_set_selinux_context_restore">還原</string>
<string name="file_properties_permission_recursive">套用到包含的檔案</string>
<string name="file_properties_checksum">總和檢查碼</string>
<string name="file_properties_checksum_compare">比較</string>
<string name="file_properties_checksum_compare_placeholder">任何總和檢查碼</string>
<string name="file_properties_checksum_compare_match_format">與 %1$s 總和檢查碼相符</string>
<string name="file_properties_checksum_compare_prefix_match_format">與 %1$s 總和檢查碼的前綴相符</string>
<string name="file_properties_checksum_compare_no_match">找不到相符的總和檢查碼</string>
<string name="file_properties_image">圖片</string>
<string name="file_properties_media_dimensions">尺寸</string>
<string name="file_properties_media_dimensions_format">%1$d \u00d7 %2$d</string>
Expand Down Expand Up @@ -399,6 +393,12 @@
<string name="file_properties_apk_signature_digests">簽名</string>
<string name="file_properties_apk_signature_digests_empty">無有效簽名</string>
<string name="file_properties_apk_past_signature_digests">舊簽名</string>
<string name="file_properties_checksum">總和檢查碼</string>
<string name="file_properties_checksum_compare">比較</string>
<string name="file_properties_checksum_compare_placeholder">任何總和檢查碼</string>
<string name="file_properties_checksum_compare_match_format">與 %1$s 總和檢查碼相符</string>
<string name="file_properties_checksum_compare_prefix_match_format">與 %1$s 總和檢查碼的前綴相符</string>
<string name="file_properties_checksum_compare_no_match">找不到相符的總和檢查碼</string>

<string name="storage_file_system_root_title">根目錄</string>
<string name="storage_list_title">儲存空間</string>
Expand Down
22 changes: 11 additions & 11 deletions app/src/main/res/values/strings.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -382,17 +382,6 @@
<string name="file_properties_permission_set_selinux_context_title">Change SELinux context</string>
<string name="file_properties_permission_set_selinux_context_restore">Restore</string>
<string name="file_properties_permission_recursive">Apply to enclosed files</string>
<string name="file_properties_checksum">Checksums</string>
<string name="file_properties_checksum_compare">Compare</string>
<string name="file_properties_checksum_compare_placeholder">Any checksum</string>
<string name="file_properties_checksum_compare_match_format">Matches %1$s checksum</string>
<string name="file_properties_checksum_compare_prefix_match_format">Matches prefix of %1$s checksum</string>
<string name="file_properties_checksum_compare_no_match">No matching checksum found</string>
<string name="file_properties_checksum_crc32" translatable="false">CRC32</string>
<string name="file_properties_checksum_md5" translatable="false">MD5</string>
<string name="file_properties_checksum_sha_1" translatable="false">SHA-1</string>
<string name="file_properties_checksum_sha_256" translatable="false">SHA-256</string>
<string name="file_properties_checksum_sha_512" translatable="false">SHA-512</string>
<string name="file_properties_image">Image</string>
<string name="file_properties_media_dimensions">Dimensions</string>
<string name="file_properties_media_dimensions_format">%1$d \u00d7 %2$d</string>
Expand Down Expand Up @@ -525,6 +514,17 @@
<string name="file_properties_apk_signature_digests">Signatures</string>
<string name="file_properties_apk_signature_digests_empty">No valid signatures</string>
<string name="file_properties_apk_past_signature_digests">Old signatures</string>
<string name="file_properties_checksum">Checksums</string>
<string name="file_properties_checksum_compare">Compare</string>
<string name="file_properties_checksum_compare_placeholder">Any checksum</string>
<string name="file_properties_checksum_compare_match_format">Matches %1$s checksum</string>
<string name="file_properties_checksum_compare_prefix_match_format">Matches prefix of %1$s checksum</string>
<string name="file_properties_checksum_compare_no_match">No matching checksum found</string>
<string name="file_properties_checksum_crc32" translatable="false">CRC32</string>
<string name="file_properties_checksum_md5" translatable="false">MD5</string>
<string name="file_properties_checksum_sha_1" translatable="false">SHA-1</string>
<string name="file_properties_checksum_sha_256" translatable="false">SHA-256</string>
<string name="file_properties_checksum_sha_512" translatable="false">SHA-512</string>

<string name="storage_file_system_root_title">Root</string>
<string name="storage_list_title">Storage</string>
Expand Down

0 comments on commit cdbd9b4

Please sign in to comment.