fix application/x-nix-nar Content-Type not being applied #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
Dec 6, 2024
girlbossceo
force-pushed
the
strawberry/send-nix-nar-content-type
branch
from
748df8c to
1461118
Compare
Signed-off-by: strawberry <[email protected]>
zhaofengli
force-pushed
the
strawberry/send-nix-nar-content-type
branch
from
1461118 to
d92359c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not the cleanest way to do it, but it worked based on my testing and I was trying to figure out an (unrelated) issue that could have had something to do with the Content-Type always being
application/octet-streamfrom Attic. Just sending this anyways because it seems unintended for this to always beapplication/octet-streamcompared to other Nix binary caches out there that do sendapplication/x-nix-nar.