Skip to content

Commit

Permalink
[KYUUBI apache#5999] loads the interval of sessionConfCache from conf…
Browse files Browse the repository at this point in the history
…igurable file in FileSessionConfAdvisor

# 🔍 Description
## Issue References 🔗

This pull request fixes the issue that FileSessionConfAdvisor failed to load the interval defined in configuration file.

## Describe Your Solution 🔧

load the Kyuubi configuration from configurable file instead of using environment parameters.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#5999 from zhaohehuhu/dev-0119.

Closes apache#5999

592d15a [hezhao2] loads the interval of sessionConfCache from configurable file in FileSessionConfAdvisor

Authored-by: hezhao2 <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
  • Loading branch information
zhaohehuhu committed Mar 21, 2024
1 parent b3b1ce7 commit 6e59a27
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ class FileSessionConfAdvisor extends SessionConfAdvisor {
}

object FileSessionConfAdvisor extends Logging {
private val reloadInterval: Long = KyuubiConf().get(KyuubiConf.SESSION_CONF_FILE_RELOAD_INTERVAL)
private val reloadInterval: Long =
KyuubiConf().loadFileDefaults().get(KyuubiConf.SESSION_CONF_FILE_RELOAD_INTERVAL)
private lazy val sessionConfCache: LoadingCache[String, JMap[String, String]] =
CacheBuilder.newBuilder()
.expireAfterWrite(
Expand Down

0 comments on commit 6e59a27

Please sign in to comment.