Skip to content

Commit

Permalink
[KYUUBI apache#6182] JDBC engine using the overlay conf as session conf
Browse files Browse the repository at this point in the history
# 🔍 Description
## Issue References 🔗

## Describe Your Solution 🔧

Like apache#6147, JDBC engine should overwriting the engine conf with the passed conf consider as the full session conf.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6182 from lsm1/branch-jdbc-engine-use-overlay-conf.

Closes apache#6182

9ca8b48 [senmiaoliu] Using the overlay conf as session conf

Authored-by: senmiaoliu <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
  • Loading branch information
lsm1 authored and zhaohehuhu committed Mar 21, 2024
1 parent 7c51e19 commit ac3277c
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class JdbcSessionImpl(
kyuubiConf.set(ENGINE_JDBC_CONNECTION_USER, user)
kyuubiConf.set(ENGINE_JDBC_CONNECTION_PASSWORD, password)
}
conf.foreach { case (k, v) => kyuubiConf.set(k, v) }
kyuubiConf
}

Expand Down

0 comments on commit ac3277c

Please sign in to comment.