Skip to content

Commit

Permalink
[KYUUBI apache#4279] Use new Apache 'closer.lua' syntax for kyuubi-do…
Browse files Browse the repository at this point in the history
…wnload to obtain engine

…ne archives

# 🔍 Description
## Issue References [4279](https://github.com/apache/kyuubi/issues/4279)🔗

This pull request fixes #

## Describe Your Solution 🔧

Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine

## Types of changes 🔖

- [x] New feature (non-breaking change which adds functionality)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6009 from sincewhen/master.

Closes apache#4279

2152a9b [yuqingyang] Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine archives

Authored-by: yuqingyang <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
  • Loading branch information
yuqingyang authored and zhaohehuhu committed Feb 5, 2024
1 parent 699e73c commit c41c5f2
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/contributing/code/building.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ For the Scala version for Spark engines, the server will look up the `SPARK_SCAL

## Building With Apache dlcdn Site

By default, we use `https://archive.apache.org/dist/` to download the built-in release packages of engines,
By default, we use `closer.lua` to download the built-in release packages of engines,
such as Spark or Flink.
But sometimes, you may find it hard to reach, or the download speed is too slow,
then you can define the `apache.archive.dist` by `-Pmirror-cdn` to accelerate to download speed.
Expand Down
6 changes: 3 additions & 3 deletions externals/kyuubi-download/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
<phase>compile</phase>
<configuration>
<skip>${spark.archive.download.skip}</skip>
<url>${spark.archive.mirror}/${spark.archive.name}</url>
<url>${spark.archive.mirror}/${spark.archive.name}?action=download</url>
</configuration>
</execution>
<execution>
Expand All @@ -62,7 +62,7 @@
<phase>compile</phase>
<configuration>
<skip>${flink.archive.download.skip}</skip>
<url>${flink.archive.mirror}/${flink.archive.name}</url>
<url>${flink.archive.mirror}/${flink.archive.name}?action=download</url>
</configuration>
</execution>
<execution>
Expand All @@ -73,7 +73,7 @@
<phase>compile</phase>
<configuration>
<skip>${hive.archive.download.skip}</skip>
<url>${hive.archive.mirror}/${hive.archive.name}</url>
<url>${hive.archive.mirror}/${hive.archive.name}?action=download</url>
</configuration>
</execution>
</executions>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
<!-- Please don't upgrade the version to 4.10+, it depends on JDK 11 -->
<antlr4.version>4.9.3</antlr4.version>
<antlr.st4.version>4.3.4</antlr.st4.version>
<apache.archive.dist>https://archive.apache.org/dist</apache.archive.dist>
<apache.archive.dist>http://www.apache.org/dyn/closer.lua</apache.archive.dist>
<atlas.version>2.3.0</atlas.version>
<bouncycastle.version>1.67</bouncycastle.version>
<codahale.metrics.version>4.2.23</codahale.metrics.version>
Expand Down

0 comments on commit c41c5f2

Please sign in to comment.