sql UI change #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
pushed a commit
that referenced
this pull request
Nov 21, 2023
### _Why are the changes needed?_ This PR is to introduce a submit SQL editor page to close apache#5366. Users then can submit SQL in SQL editor page to retrieve, update or do other data manipulations by Spark engine with this feature. Once users open up a new tab in SQL editor, a new connection(session) is established with the a Kyuubi server instance. After that, users can input their SQL statements in a text box provided on the page and select the desired number of data rows to be shown in result from a dropdown list located at the right side of the run button. When the statement is executed in one of server instances, the execution status of the job is displayed to the user. After the statement is executed successfully , the result is displayed in the bottom of page for users.   ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ No Closes apache#5616 from zhaohehuhu/dev-1103. Closes apache#5366 078d19e [William Tong] code optimize (#9) 1d839bc [William Tong] code change (#8) ddffd19 [William Tong] fix code conflict in layout (#7) f1fc9a2 [William Tong] UI change (#6) 265f02d [William Tong] sql UI change (#5) 4bb22f0 [William Tong] Merge branch 'master' into dev-1103 065a497 [William Tong] Merge master into branch (#4) 3438012 [William Tong] Merge pull request #3 from zhaohehuhu/dev-1103-3 a374028 [weitong] add error message for sql page f04acf2 [William Tong] Merge branch 'master' into dev-1103 93fa6a2 [William Tong] Merge pull request #2 from zhaohehuhu/dev-1103-2 f0669ba [weitong] fix ecdbe5c [hezhao2] fix 531761d [hezhao2] change TabPaneName to TabPanelName 466a5ba [hezhao2] remove api2 ab0661f [hezhao2] change format for table header 5f4bca5 [hezhao2] move logo picture to images folder 159c35a [hezhao2] change layout 7379c4e [weitong] code change 0ddc6d5 [weitong] sql lab page dda47bd [hezhao2] add license 9f80e20 [weitong] sql page test Lead-authored-by: He Zhao <[email protected]> Co-authored-by: William Tong <[email protected]> Co-authored-by: hezhao2 <[email protected]> Co-authored-by: weitong <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?