fix: avoid logging CREATE TABLE exception (sqlancer#875)

* fix: avoid logging CREATE TABLE exception

* Update TestLoggableFactory.java

* Update SQLLoggableFactory.java

We need to check the query in the constructor

* Update SQLLoggableFactory.java

Fix wrong indent.

* fix: check couldAffectSchema before setting false

* fix: revise check query string

---------

Co-authored-by: Yichen Yan <[email protected]>

src/sqlancer/common/query/SQLQueryAdapter.java

@@ -24,7 +24,11 @@ public SQLQueryAdapter(String query, boolean couldAffectSchema) {
     }
 
     public SQLQueryAdapter(String query, ExpectedErrors expectedErrors) {
-        this(query, expectedErrors, false);
+        this(query, expectedErrors, guessAffectSchemaFromQuery(query));
+    }
+
+    private static boolean guessAffectSchemaFromQuery(String query) {
+        return query.contains("CREATE TABLE") && !query.startsWith("EXPLAIN");
     }
 
     public SQLQueryAdapter(String query, ExpectedErrors expectedErrors, boolean couldAffectSchema) {
@@ -46,8 +50,10 @@ private String canonicalizeString(String s) {
     }
 
     private void checkQueryString() {
-        if (query.contains("CREATE TABLE") && !query.startsWith("EXPLAIN") && !couldAffectSchema) {
-            throw new AssertionError("CREATE TABLE statements should set couldAffectSchema to true");
+        if (!couldAffectSchema) {
+            if (guessAffectSchemaFromQuery(query)) {
+                throw new AssertionError("CREATE TABLE statements should set couldAffectSchema to true");
+            }
         }
     }
 

test/sqlancer/TestLoggableFactory.java

@@ -0,0 +1,17 @@
+package sqlancer;
+
+import org.junit.jupiter.api.Test;
+import sqlancer.common.log.SQLLoggableFactory;
+import sqlancer.common.query.SQLQueryAdapter;
+
+public class TestLoggableFactory {
+
+    @Test
+    public void testLogCreateTable() {
+        String query = "CREATE TABLE t1 (c1 INT)";
+        SQLLoggableFactory logger = new SQLLoggableFactory();
+        SQLQueryAdapter queryAdapter = logger.getQueryForStateToReproduce(query);
+        assert (queryAdapter.couldAffectSchema());
+    }
+
+}