-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple notebook comparing the results of ExactGP and viGP #50
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 95.98% 96.01% +0.02%
==========================================
Files 44 44
Lines 3541 3541
==========================================
+ Hits 3399 3400 +1
+ Misses 142 141 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks! I feel it could benefit a bit from a discussion on when one should use a fully Bayesian (HMC/NUTS) approach vs variational inference approximation. In my experience, HMC/NUTS: SVI: |
Would you like me to add this to the notebook or perhaps it belongs in a README/docs somewhere? I am definitely not an authority on these matters but I can try to explain. |
I would add it to the notebook for now. I plan to add some general advice to the README later on or maybe make a separate tutorial. |
Ok will do. I'll add your text to the notebook a little later and will push the changes. I can also use this PR to run the smoke tests on all of the notebooks. Stay tuned. |
Sounds good - looking forward to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I noticed it takes almost 2 hours for the notebook smoke tests. Perhaps we can add lines like num_samples=5 if smoke_test else 500
to the notebooks to make their testing faster. This can be addressed in a separate issue / pull request.
I've created a simple example for people to compare the results of an
ExactGP
and aviGP
. Nothing too fancy here.