Fix JS falsy comparison #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperAuguste
force-pushed
the
auguste/js-falsy-noooo
branch
from
2b496f4 to
e3cc045
Compare
Vexu
approved these changes
Feb 15, 2024
|
Confirmed locally :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript is weird lol
This fixes ZLS not starting automatically.
""as the path means that Zig and/or ZLS will be looked up in PATH as intended, whereasundefinedis an undesired state. Interestingly,undefinedshould never actually occur as""is the default, so this fix technically does nothing. :PNot sure if
""to designate looking up by PATH is the best approach, but I'm not sure what the convention is elsewhere.Closes #176