code formatting, strict typechecking, linting, code cleanup and bugfixes #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the child process api of nodejs is good enough without any wrapper code
Vexu
approved these changes
Apr 1, 2024
src/extension.ts
Outdated
| activateZls(context) | ||
| }); | ||
| export async function activate(context: vscode.ExtensionContext) { | ||
| await setupZig(context); |
There was a problem hiding this comment.
This previously used finally to activate the rest of the extension even if setupZig failed for some reason. Will that sill happen?
There was a problem hiding this comment.
Oh, I though there was a call to then instead of finally which is why I changed it. Let me correct that.
|
I wanted to link the release notes in the new Zig version notification so I pushed the change here as it was going to conflict. |
- add `typescript` - add `typescript-eslint` - make `@vscode/vsce` a dev dependency - make `esbuild` a dev dependency
The legacy config system will be deprecated in ESLint v9.0.0
the progress message has also been update to not show "Zig" or "ZLS" twice
ast-check doesn't care about the current working directory
It is possible to ignore the initial setup and set the paths manually. If that happens, no initial setup should happen.
The check that `zig.path` is set has been removed because ZLS is usable without Zig.
Sending `null` instead of `"zig"` to ZLS will make it lookup in `$PATH` instead of complaining that `"zig"` is not a valid file path.
just image you are writing Zig
This option has been removed in 47e6669 which I believe was accidental.
This will ensure that when handling responses from the user, all possible responses are exhaustiveness handled.
|
@Vexu I accidentally force pushed to this branch which removed the commits you have added. I was about to restore them but then your merged this PR a few seconds before I pushed again. |
|
No worries, I pushed them directly to master so that I could release a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some of the work I did on this extension that excludes any new major features I planned. I can split this into multiple PRs or remove some parts that are undesired if that helps with getting this reviewed and merged.
There are a lot of changes is in this PR. Here are some of the notable changes:
zig.zls.pathzig.pathandzig.zls.pathare set