improve formatting integration #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLS does can format without needing to wait for `zig fmt` to compile. It will fallback to the extension if ZLS is not running
Vexu
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over time, I've see users report issues with code formatting provided by this extension.
Unfortunately, I have not been able to reproduce any of these issues. They may just be caused by the fact that
zig fmtis JIT compiled or something unrelated to that.These changes should (hopefully) make code formatting more reliable by applying the following changes:
zig fmtwhen starting the extensionI also changed the default formatting provider from
extensiontozls. I've made sure that formatting can fallback to the extension provider if ZLS is not running. Perhaps this makes theformattingProviderunnecessary all together but I will leave that to another time.