CBE: implement mod, divFloor, divTrunc, and enable more passing tests #11229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
requested changes
Mar 19, 2022
src/link/C/zig.h
Outdated
Comment on lines
772
to
775
| #define zig_div_trunc_int(ZigType, CType) \ | ||
| static inline CType zig_div_trunc_##ZigType(CType numerator, CType denominator) { \ | ||
| return numerator / denominator; \ | ||
| } |
There was a problem hiding this comment.
If this is how div trunc for integers is defined then why don't we simply emit a / b instead of a call to this function? Looks like before this change, that's exactly what we did. Was there a problem with it?
There was a problem hiding this comment.
Very true, this was only convenient for a unified interface but we shouldn't need this code at all.
I changed the code in genBody() to instead selectively dispatch to airBinOp(..., " / ") or airBinOpBuiltinCall(..., "div_trunc") depending on the type, PTAL.
|
When I did some work in this I had added some more tests, maybe they could be useful (unfortunately I don't remember if I did for a specific reason lol). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enables the newly-passing
math.zigtests, while splitting off the half-precision floating point tests until #10771 is merged.