Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage2: disable some parts of @Type, add @Int, @Float, @Array #13982

Closed
wants to merge 19 commits into from

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Dec 16, 2022

Ref: #10710

@tauoverpi
Copy link
Contributor

Wonder if @Array is needed given that it can be constructed using syntax alone [len:sentinel]T and [len]T which I assume is the desired notation.

@InKryption
Copy link
Contributor

Wonder if @Array is needed given that it can be constructed using syntax alone [len:sentinel]T and [len]T which I assume is the desired notation.

Could argue the same for pointers, but I would contend that nobody would want to, given the numerous permutations (*align(4) const allowzero T vs [*:s]addrspace(.fs) volatile T).
Just seems more simple to have a way to reify it, the same as the other syntactically constructible types here.

@tauoverpi
Copy link
Contributor

The argument against pointer would likely be performance as otherwise it's not too bad to implement just a bit annoying.

@nektro nektro closed this Dec 24, 2022
@nektro
Copy link
Contributor Author

nektro commented Dec 24, 2022

unable to rebase without redoing the work because of too many blob changes

anyone else is welcome to pick this up, wont delete the branch for a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants