windows: support UNC paths #15283
Closed
windows: support UNC paths #15283
+13
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ziglang#8205 and ziglang#12729. The old method of prepending `\??\` at the start of the DOS path produced invalid strings for UNC paths (such as those found in WSL). Instead, we rely on the conversion routine in ntdll, which should handle all current and future edge cases properly.
|
Unfortunately In particular: #7537 (comment)
For more context, see #7664 which is where the current logic (specifically to avoid depending on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8205 and #12729.
The old method of prepending
\??\at the start of the DOS path produced invalid strings for UNC paths (such as those found in WSL). Instead, we rely on the conversion routine in ntdll, which should handle all current and future edge cases properly.