std.hash_map: adding a rehash() method #19923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjbq7
force-pushed
the
rehash-again
branch
2 times, most recently
from
82a8478 to
24a1c54
Compare
linusg
suggested changes
May 10, 2024
|
@linusg thanks! fixed those 3 comments, and rebased on master again. |
mrjbq7
force-pushed
the
rehash-again
branch
2 times, most recently
from
ad2ebd0 to
51e0b86
Compare
|
I'll just keep it rebased on master until @andrewrk tells me he doesn't like this PR. |
|
To mirror my comment in #17851: We can remove the user burden of calling rehash manually by requiring any adapter context to have an additional |
|
After this is merged, I'd be happy to fix #7494 (if it turns out to still be a problem). |
andrewrk
added
standard library
igor84
pushed a commit
to igor84/zig
that referenced
this pull request
Aug 11, 2024
SammyJames
pushed a commit
to SammyJames/zig
that referenced
this pull request
Aug 13, 2024
Rexicon226
pushed a commit
to Rexicon226/zig
that referenced
this pull request
Aug 13, 2024
richerfu
pushed a commit
to richerfu/zig
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this resurrects the recently closed #17890.
This allows a highly fragmented HashMap to have tombstones removed as the values are all rehashed.
It would be nice to make this
rehash()automatically, but that currently presents a challenge where it doesn't work with adapted contexts since the keys are not preserved in the map for re-hashing and the hash value is not stored currently, and the non-adapted contexts require a bit of additional book-keeping to check before calling rehash().This is a partial fix for #17851, but requires the user to call
rehash()periodically to get the benefit.