Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZON #20271
base: master
Are you sure you want to change the base?
ZON #20271
Changes from all commits
2009cd3
b4b3d12
6fd7fba
f5fb430
909b072
f8470d4
ec2f582
8f1a665
7709564
d5301b4
12c3530
3d1e01c
30cbe7b
72d17c0
41b1880
7ddfae1
cbc34c7
5bd6477
a9b2a93
e45b8de
840e960
1edcd45
9156de2
93754f4
8fefd9b
80c4de8
d1852ba
eae9770
9cd6219
8dc3413
54269df
423147a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imports now store result types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A possible ZIR optimization here would now be to replace the
rvalue
call below with special handling in thety
case, since Sema will do the coercion for us. Not a merge blocker, just worth noting!