Report mismatched parentheses before more specific errors #20764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tau-dev
force-pushed
the
check-parens
branch
3 times, most recently
from
d373770 to
75304ad
Compare
tau-dev
force-pushed
the
check-parens
branch
2 times, most recently
from
e9b9573 to
ea6aaeb
Compare
Addresses ziglang#18597 (the specific case presented there, but not the general goal of that issue) by checking for mismatched parentheses after a parser error. Unclosed parens are often a root cause of otherwise much-more-cryptic errors, so reporting them should have priority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #18597 (the specific case presented there, but not the general goal of that issue) by checking for mismatched parentheses after a parser error. Unclosed parens are often a root cause of otherwise much-more-cryptic errors, so reporting them should have priority.