build: watch: Support for multi mount point file systems. #20844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. It looks like a dupe of #20672. I'm sorry for not fixing it yet, I will look at both implementations and make sure it gets solved soon. |
|
I'm sorry I didn't see the first implementation of this, that's complete carelessness from me. But looks like I had the right kind of idea looking from looking at #20672 though . This can probably be closed if the work's already been done. |
|
Closed this as the implementation didn't do much different to #20672. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On distros that have multiple mount points for different parts of the root directory (like Fedora linux), the existing watch implementation did not account for the need for multiple fannotify file descriptors per mount point: When it hit a directory on a different mount point to the rest of the files being watched, fanotify_mark would return NotSameFileSystem and throw a fatal error. This PR adds a unique file fd per mount point, lazily creating them as directories are added to the watch list.
This is my first contribution to the Zig project so please feel free to bin this change, or provide feedback and changes if you think it's of suitable quality.