Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.Build.TranslateC: replace addIncludeDir with variants with LazyPath/library names #20851

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

paperdave
Copy link
Contributor

addIncludeDir takes a string slice, and does not support LazyPath and other include dir params. To match with Build.Module and Build.Step.Compile, i've adapted the following definitions to TranslateC

  • addAfterIncludePath
  • addSystemIncludePath
  • addIncludePath (changed from "dir" to "path" to match other apis)
  • addConfigHeader
  • addSystemFrameworkPath
  • addFrameworkPath

possible solution for #20649, though motivated by my need to use addIncludePath but it taking a slice.

i haven't thoroughly tested these besides addIncludePath in my own project. i am assuming translate-c supports the same set of flags that build-* supports, and that the existing code for passing the flags works.

@andrewrk andrewrk merged commit 085cc54 into ziglang:master Sep 26, 2024
10 checks passed
@andrewrk
Copy link
Member

Nice, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants