std.Build.TranslateC
: replace addIncludeDir
with variants with LazyPath/library names
#20851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addIncludeDir
takes a string slice, and does not support LazyPath and other include dir params. To match withBuild.Module
andBuild.Step.Compile
, i've adapted the following definitions to TranslateCaddAfterIncludePath
addSystemIncludePath
addIncludePath
(changed from "dir" to "path" to match other apis)addConfigHeader
addSystemFrameworkPath
addFrameworkPath
possible solution for #20649, though motivated by my need to use addIncludePath but it taking a slice.
i haven't thoroughly tested these besides
addIncludePath
in my own project. i am assuming translate-c supports the same set of flags thatbuild-*
supports, and that the existing code for passing the flags works.