-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement packed struct equality #21679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
fea8e18
to
aa38854
Compare
I don't see an explicit mention (nor test) of this, but IMO |
It's a compile error because comparisons are peer resolves, and two different packed structs types cannot coerce into each other. |
aa38854
to
a7930d8
Compare
@andrewrk will you write the release notes or should I? |
I will if you don't. You're certainly welcome to lighten my load :-) |
closes #21678