Attach minimum Linux versions to provided libcs + incorporate ABI in VersionRange.default()
#22225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c entry. (With the exception of x86 since that was available from the beginning.) These were determined by analyzing the full, reconstructed Git history of the Linux kernel here: https://landley.net/kdocs/fullhist
The old logic only checked it for macOS, but we also need it to be checked for Linux now.
This is necessary to pick out the correct minimum OS version from the std.zig.target.available_libcs list.
alexrp
force-pushed
the
libc-linux-os-version
branch
from
0e9e85d to
e8006d5
Compare
linusg
reviewed
Dec 19, 2024
alexrp
force-pushed
the
libc-linux-os-version
branch
from
e8006d5 to
1303109
Compare
|
@alexrp I believe 0ef01c5 created a circular dependency when starting from Os.Tag and wanting a default Abi for that target:
Am I misunderstanding the new API? Or is this an accidental dependency? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends what we already do in
std.zig.target.canBuildLibC()for macOS to Linux. Additionally,std.Target.Os.VersionRange.default()is changed to incorporate the ABI into its decision so that it can pick out the right entry instd.zig.target.available_libcs.