Module: keep frame pointer in ReleaseSmall on x86 #22271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On x86 and x86_64 keeping the frame pointer usually reduces binary size, even for simple programs:
A bigger benchmark is the Zig compiler:
With no changes to anything on master branch:
Adding
.omit_frame_pointer = false
inaddCompilerStep
inbuild.zig
:x86 seems to be a bit of a special case. I couldn't find any other architecture where this reduces binary size.
Progress towards #22270