std.simd.suggestVectorLengthForCpu: fix crashing edge cases #23915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Fri3dNstuff wants to merge 2 commits into ziglang:master from Fri3dNstuff:suggest-vec-length

+37 −43

Contributor

Fri3dNstuff commented May 17, 2025

This PR fixes two edge cases in the function std.simd.suggestVectorLengthForCpu which previously caused a compile error, namely:

a type input of length greater than 8192 bytes (reaching unreachable)
a RISC-V CPU with features .v and .zvl65536b (attempting to assign 65536 to a u16)

Fri3dNstuff added 2 commits

May 16, 2025 19:15


          Use logarithms of bit sizes in vector-length-suggestion computation

266c35a


          Remove useless 'else'

cb94789

alexrp self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet