std.Target: add vita os #24527
Open
std.Target: add vita os #24527
+27
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
reviewed
Jul 21, 2025
alexrp
reviewed
Jul 21, 2025
Co-authored-by: Alex Rønne Petersen <[email protected]>
alexrp
reviewed
Jul 21, 2025
Comment on lines
+6353
to
+6357
| .vita => { | ||
| // LLVM doesn't support this target, so we | ||
| // have to add this manually | ||
| try argv.append("-D__vita__"); | ||
| }, |
There was a problem hiding this comment.
This should rather go near where we define GLIBC_MINOR and others.
alexrp
reviewed
Jul 21, 2025
| @@ -261,6 +262,7 @@ const targets = [_]std.Target.Query{ | |||
| .{ .cpu_arch = .thumb, .os_tag = .windows, .abi = .gnu }, | |||
| .{ .cpu_arch = .thumb, .os_tag = .windows, .abi = .itanium }, | |||
| .{ .cpu_arch = .thumb, .os_tag = .windows, .abi = .msvc }, | |||
| .{ .cpu_arch = .thumb, .os_tag = .vita, .abi = .eabihf }, | |||
alexrp
reviewed
Jul 21, 2025
Comment on lines
+70
to
72
| .{ .cpu_arch = .arm, .os_tag = .vita, .abi = .eabihf }, | ||
| // .{ .cpu_arch = .arm, .os_tag = .uefi, .abi = .eabi }, | ||
| // .{ .cpu_arch = .arm, .os_tag = .uefi, .abi = .eabihf }, |
There was a problem hiding this comment.
Suggested change
| .{ .cpu_arch = .arm, .os_tag = .vita, .abi = .eabihf }, | |
| // .{ .cpu_arch = .arm, .os_tag = .uefi, .abi = .eabi }, | |
| // .{ .cpu_arch = .arm, .os_tag = .uefi, .abi = .eabihf }, | |
| // .{ .cpu_arch = .arm, .os_tag = .uefi, .abi = .eabi }, | |
| // .{ .cpu_arch = .arm, .os_tag = .uefi, .abi = .eabihf }, | |
| .{ .cpu_arch = .arm, .os_tag = .vita, .abi = .eabihf }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.