Skip to content

flate zlib fix end of block reading #24704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Conversation

ianic
Copy link
Contributor

@ianic ianic commented Aug 5, 2025

n is wanted number of bits to toss
buffered_n is actual number of bytes in next_int

Fixes: #24695

`n` is wanted number of bits to toss
`buffered_n` is actual number of bytes in `next_int`
@andrewrk
Copy link
Member

andrewrk commented Aug 5, 2025

Thanks! Can you check if this allows you to revert a6f7927 by setting Bits to usize?

@andrewrk andrewrk merged commit d214910 into ziglang:master Aug 6, 2025
12 checks passed
ianic added a commit to ianic/zig that referenced this pull request Aug 6, 2025
After ziglang#24704 32-bit platforma build passes with usize Bits instead of
u64. There are two tests which are testing invalid inputs and raise
different error in 32 than on 64 bit platforma now.
ianic added a commit to ianic/zig that referenced this pull request Aug 6, 2025
After ziglang#24704 32-bit platform build passes with usize Bits instead of
u64. There are two tests which are testing invalid inputs and raise
different error in 32 than on 64 bit platform now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Working with flate.Decompress is maybe buggy
2 participants