Skip to content

std: use non-exhaustive enums from crc module #4216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2020
Merged

std: use non-exhaustive enums from crc module #4216

merged 1 commit into from
Jan 18, 2020

Conversation

daurnimator
Copy link
Contributor

Un-reverts PR #3118

@daurnimator daurnimator added the standard library This issue involves writing Zig code for the standard library. label Jan 18, 2020
@daurnimator daurnimator requested a review from tiehuis January 18, 2020 01:59
tiehuis
tiehuis approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@tiehuis tiehuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewrk andrewrk merged commit 9e6e1e5 into ziglang:master Jan 18, 2020
@daurnimator daurnimator deleted the crc-non-exhaustive-enum branch January 18, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiehuis tiehuis tiehuis approved these changes

Assignees
No one assigned
Labels
standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daurnimator @tiehuis @andrewrk