-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure version-specific unit tests cover command sending format #639
Conversation
I've migrated A future PR will add end-to-end testing of the entire command serialization format and adapter response for every EZSP version, hopefully like we do in zigpy-znp. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #639 +/- ##
==========================================
- Coverage 99.16% 99.10% -0.06%
==========================================
Files 50 50
Lines 3460 3462 +2
==========================================
Hits 3431 3431
- Misses 29 31 +2 ☔ View full report in Codecov by Sentry. |
In the future, we need to migrate bellows to a more robust framework that tests end-to-end command serialization and response parsing. Until then, I've replaced all blind mocks with those that also try to serialize the command.
There was a single error with EZSPv8 that has since been corrected.
Fixes #640