Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Giex GX02 quirk to V2 #3394

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

prairiesnpr
Copy link
Contributor

@prairiesnpr prairiesnpr commented Oct 2, 2024

Proposed change

Convert GX02 Quirk to a V2 Quirk. Add additional functionality.

Additional information

  1. Requires: Support Timestamp class Sensor zha#222
    or Support Timestamp Sensor - Use Subclass zha#224
  2. Device reports temperature, but it's always 0, so I'm not adding an entity.
  3. The device supports an onboard schedule, details below in case someone wants to implement it. I don't see a clean way to implement it, nor do I think it would be very useful, so I skipped it.
  4. After pairing, ZHA must be reloaded for the Summation delivered sensor to show.

image

Setting on board schedule.

### 14 Byte Data Packet ###
[0-1] Message id, increments by 1 
[2] DP Id (0x71)
[3] DP Type (Raw [0x00])
[4-5] Never changed, always 0x0008
[6] Action 0x10: Duration based, 0x11: Volume Based, 0x01: Delete Schedule
[7] Schedule id, 0 indexed
[8] Days of week schedule is active, bitfield [NA, SUN, MON, TUE, WED, THU, FRI, SAT]
[9] Start time HH, max 23
[10] Start time MM, max 59
[11-13] Set point in time(seconds) or volume, max 86,399 seconds or 6500L

Closes: #3052, Closes: #3209

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (7816838) to head (4e26fc7).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3394      +/-   ##
==========================================
+ Coverage   88.72%   88.78%   +0.05%     
==========================================
  Files         306      306              
  Lines        9813     9858      +45     
==========================================
+ Hits         8707     8752      +45     
  Misses       1106     1106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prairiesnpr prairiesnpr changed the title [RFC] Convert Giex GX02 quirk to V2 Convert Giex GX02 quirk to V2 Oct 4, 2024
@prairiesnpr prairiesnpr force-pushed the giex-valve-02 branch 2 times, most recently from 907a4d3 to 693aa6d Compare October 7, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant