-
Notifications
You must be signed in to change notification settings - Fork 897
Add Telink devices with custom ZigbeeTlc firmware quirk
#3719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3719 +/- ##
==========================================
+ Coverage 89.87% 90.52% +0.64%
==========================================
Files 320 324 +4
Lines 10381 10626 +245
==========================================
+ Hits 9330 9619 +289
+ Misses 1051 1007 -44 ☔ View full report in Codecov by Sentry. |
046a8ee to
7516a67
Compare
a7bcfc2 to
ad6697a
Compare
ad6697a to
1da86f9
Compare
ZigbeeTlc firmware
|
ZHA seems to be ignoring the |
ZigbeeTlc firmwareZigbeeTlc firmware quirk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
| off_value=1, | ||
| on_value=0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think we could also use force_inverted for this? Shouldn't really make a difference though.
Proposed change
Adds quirk for devices that are originally Bluetooth devices but can be modified to use ZigBee with a custom firmware
Edit: Some of these are already Zigbee devices but can be differentiated by the
-zpostfix from the ones with original fw, or in case of the tuya devices because they actually also have the correct model and manufacturer set ^^Additional information
Checklist
pre-commitchecks pass / the code has been formatted using Black