-
Notifications
You must be signed in to change notification settings - Fork 879
Add Schneider Electric smoke alarms #3897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3897 +/- ##
==========================================
+ Coverage 91.17% 91.19% +0.02%
==========================================
Files 334 335 +1
Lines 10855 10886 +31
==========================================
+ Hits 9897 9928 +31
Misses 958 958 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Successfully tested the "test mode" of the smoke alarm. Toggling the switch activates smoke alarm sound. However, after around 15 seconds, test alarm stops, but the switch entity remains in "on" state. Going into "Manage zigbee device" and re-reading So my guess is that ZHA doesn't get updated attribute state. @TheJulianJES is there something I can do to fix this? |
76b7ceb
to
e810b85
Compare
I added This fixed the issue, now |
Do you have any comments regarding the following issues?
|
You'll need to remove the device class for that entity for now. It's a HA thing that years isn't allowed for the duration device class. We'd need an accepted architecture proposal, similar to this, before we can make changes to HA: home-assistant/architecture#1206
We've generally not categorized switch entities as "diagnostic", as you're actively "configuring" the device with them. Diagnostics is generally reserved for read-only sensors (and alike), but "Test mode" might be a bit of an exception here though. I'd still keep it in configuration for now. If we want to adjust it, we can add a new discovery schema to ZHA here: https://github.com/zigpy/zha/blob/695475a927451524475bdcef90a25177727e2345/zha/application/discovery.py#L206-L215 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good now. Thanks!
Proposed change
Add support for Schneider Electric Smoke Alarms.
Reference to the original issue #1705
Specs: ZB Spec - Smoke Alarm -110422.pdf
Additional information
There are two issues from the logs:
Checklist
pre-commit
checks pass / the code has been formatted using Black