-
Notifications
You must be signed in to change notification settings - Fork 876
Added a guide on writing V2 quirks #4349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4349 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 358 358
Lines 11919 11919
=======================================
Hits 10981 10981
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for this! Wondering if the PR supersede this previous not-yet-merged PR with "Initial quirks v2 documentation thoughts"? Also see the related discussions here which is a request for a complete guide on how to write v2 quirks for ZHA: PS: FYI, btw, I submitted a PR for a guide on how-to test custom quirks in zha as a compliment to this howto guide: |
I don't think so, cuz the PR you linked goes a lot more in depth regarding the actual API - signatures, meaning of arguments and so on. This should definitely be available for people who don't want to or cannot read the actual code to understand what a function does. This PR is about how to write a quirk, whereas the one you linked focuses on how to write a quirk. |
Proposed change
Adding a zero-to-hero guide on writing V2 quirks, as I was asked to in this discussion.