Skip to content

Conversation

3reality-support
Copy link

@3reality-support 3reality-support commented Sep 20, 2025

Proposed change

This PR has added button quirk v2 and some basic attributes, automation, and private clusters
1.cancel_bouble_click----cancel button double-click function

Additional information

This PR fixes the issue where buttons cannot be automated in zha,and do I need to remove the previously submitted button.py?

Device diagnostics

zha-01JEN6GWZMMHTF70X8QNKV91VP-Third Reality, Inc 3RSB22BZ-0d377385e48c0e61cd04ea86b316bf17.json

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

Copy link

codecov bot commented Sep 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.14%. Comparing base (500e74e) to head (26a4356).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4352      +/-   ##
==========================================
+ Coverage   92.12%   92.14%   +0.01%     
==========================================
  Files         358      359       +1     
  Lines       11917    11942      +25     
==========================================
+ Hits        10979    11004      +25     
  Misses        938      938              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@3reality-support
Copy link
Author

3reality-support commented Sep 20, 2025

@TheJulianJES codecov fail , please advise on how to fix it

@TheJulianJES TheJulianJES added manufacturer This request was made by the device's manufacturer needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). labels Sep 24, 2025
@3reality-support
Copy link
Author

@TheJulianJES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manufacturer This request was made by the device's manufacturer needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants