Skip to content

Commit

Permalink
Always set effect on members
Browse files Browse the repository at this point in the history
Changing any other attributes always turns off the effect at the moment, so we need to pass that to the members.
  • Loading branch information
TheJulianJES committed Sep 24, 2024
1 parent 32e87ef commit 225fa45
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions zha/application/platforms/light/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1243,8 +1243,8 @@ def _make_members_assume_group_state(
update_params[ATTR_COLOR_MODE] = self._color_mode
update_params[ATTR_XY_COLOR] = self._xy_color

if service_kwargs.get(ATTR_EFFECT) is not None:
update_params[ATTR_EFFECT] = self._effect
# setting any other attribute will turn the effect off, so we always set this
update_params[ATTR_EFFECT] = self._effect

for platform_entity in self.group.get_platform_entities(Light.PLATFORM):
platform_entity._assume_group_state(update_params)
Expand Down

0 comments on commit 225fa45

Please sign in to comment.