Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yet another config double conversion #142

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Fix yet another config double conversion #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58dd010
Fix yet another config double conversion
puddly Aug 6, 2024
9785a46
Fix unit test relying on radio library schema conversion
puddly Aug 6, 2024
7daacaa
Fix it for both parametrized tests
puddly Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/test_gateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,10 @@ async def test_gateway_initialize_bellows_thread(
) as mock_new:
zha_gw = Gateway(zha_data)
await zha_gw.async_initialize()
assert mock_new.mock_calls[-1].kwargs["config"][CONF_USE_THREAD] is thread_state
assert (
mock_new.mock_calls[-1].kwargs["config"].get(CONF_USE_THREAD, True)
is thread_state
)
await zha_gw.shutdown()


Expand Down
2 changes: 1 addition & 1 deletion zha/application/gateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def get_application_controller_data(self) -> tuple[ControllerApplication, dict]:
):
app_config[CONF_USE_THREAD] = False

return radio_type.controller, radio_type.controller.SCHEMA(app_config)
return radio_type.controller, app_config

@classmethod
async def async_from_config(cls, config: ZHAData) -> Self:
Expand Down
Loading