-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak available handling #30
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -1154,9 +1154,7 @@ async def test_last_feeding_size_sensor_v2( | |||||
|
||||||
|
||||||
@pytest.mark.looptime | ||||||
async def test_device_counter_sensors( | ||||||
zha_gateway: Gateway, caplog: pytest.LogCaptureFixture | ||||||
) -> None: | ||||||
async def test_device_counter_sensors(zha_gateway: Gateway) -> None: | ||||||
"""Test quirks defined sensor.""" | ||||||
|
||||||
coordinator = zha_gateway.coordinator_zha_device | ||||||
|
@@ -1179,11 +1177,36 @@ async def test_device_counter_sensors( | |||||
|
||||||
assert entity.state["state"] == 2 | ||||||
|
||||||
coordinator.available = False | ||||||
await asyncio.sleep(120) | ||||||
|
||||||
@pytest.mark.looptime | ||||||
async def test_device_unavailable_skips_entity_polling( | ||||||
zha_gateway: Gateway, | ||||||
elec_measurement_zha_dev: Device, # pylint: disable=redefined-outer-name | ||||||
caplog: pytest.LogCaptureFixture, | ||||||
) -> None: | ||||||
"""Test quirks defined sensor.""" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
assert not elec_measurement_zha_dev.is_coordinator | ||||||
assert not elec_measurement_zha_dev.is_active_coordinator | ||||||
entity_id = "sensor.fakemanufacturer_fakemodel_e769900a_basic_rssi" | ||||||
entity = get_entity(elec_measurement_zha_dev, entity_id) | ||||||
assert entity is not None | ||||||
|
||||||
assert entity.state["state"] is None | ||||||
|
||||||
# simulate counter increment on application | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
elec_measurement_zha_dev.device.rssi = 60 | ||||||
|
||||||
await asyncio.sleep(zha_gateway.global_updater.__polling_interval + 2) | ||||||
await zha_gateway.async_block_till_done(wait_background_tasks=True) | ||||||
|
||||||
assert entity.state["state"] == 60 | ||||||
|
||||||
elec_measurement_zha_dev.on_network = False | ||||||
await asyncio.sleep(zha_gateway.global_updater.__polling_interval * 2) | ||||||
await zha_gateway.async_block_till_done(wait_background_tasks=True) | ||||||
|
||||||
assert ( | ||||||
"counter_1: skipping polling for updated state, available: False, allow polled requests: True" | ||||||
in caplog.text | ||||||
"00:0d:6f:00:0a:90:69:e7-1-0-rssi: skipping polling for updated state, " | ||||||
"available: False, allow polled requests: True" in caplog.text | ||||||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.