Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some mypy excludes #59

Merged
merged 13 commits into from
Jul 9, 2024
Merged

Remove some mypy excludes #59

merged 13 commits into from
Jul 9, 2024

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Jul 2, 2024

Typing is not actually enabled because we do not expose py.typed.

Progress:

  • arg-type
  • assignment
  • attr-defined
  • call-arg
  • dict-item
  • index
  • misc
  • no-any-return
  • no-untyped-call
  • no-untyped-def
  • override
  • return-value
  • union-attr
  • var-annotated

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (a77caee) to head (fbf254f).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #59      +/-   ##
==========================================
- Coverage   95.37%   95.30%   -0.07%     
==========================================
  Files          61       61              
  Lines        9337     9268      -69     
==========================================
- Hits         8905     8833      -72     
- Misses        432      435       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly marked this pull request as draft July 5, 2024 20:33
@puddly puddly changed the title Advertise typing with py.typed Remove some mypy excludes Jul 9, 2024
@puddly puddly marked this pull request as ready for review July 9, 2024 22:38
@puddly
Copy link
Contributor Author

puddly commented Jul 9, 2024

Save for deleted constants, these changes should all be lib-internal.

Copy link
Contributor

@dmulcahey dmulcahey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@puddly puddly merged commit 155b877 into zigpy:dev Jul 9, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants