Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Codecov v4 changes #245

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

TheJulianJES
Copy link
Contributor

@TheJulianJES TheJulianJES commented Apr 11, 2024

DRAFT -- do not merge yet (needs below workflow PR merged first, CI will fail for now)

Passes the CODECOV_TOKEN GH secret to the shared workflow.
Related PR with more information:

@TheJulianJES TheJulianJES reopened this Apr 11, 2024
@TheJulianJES TheJulianJES marked this pull request as ready for review April 11, 2024 15:39
@TheJulianJES
Copy link
Contributor Author

The Python test failure is unexpected/unrelated. I'll get all other PRs done first and then take a look at this.
Since it's unrelated, we could still consider merging this anyway to have Codecov working on the PR that fixes the Python tests.

@TheJulianJES
Copy link
Contributor Author

Seems to break with zigpy 0.60.3 already.
Both caused by (at least):

(still taking a look for now)

@puddly
Copy link
Collaborator

puddly commented Apr 11, 2024

Ah, you're right. We don't run CI on radio libraries when making zigpy changes and ZNP hasn't needed any since December! Perhaps that would be something to explore in the future.

@TheJulianJES
Copy link
Contributor Author

#246 should fix the test issues. CI won't work on that at all right now, so I'll merge this Codecov PR as-is, then rebase the test fix PR and merge that (and have a green tree again).

@TheJulianJES TheJulianJES merged commit 7171c6a into zigpy:dev Apr 11, 2024
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants