remove Type.array_index

zigtools · Oct 5, 2023 · 2312eca · 2312eca
1 parent f146a15
commit 2312eca
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 15 deletions.
diff --git a/src/analysis.zig b/src/analysis.zig
@@ -1592,9 +1592,6 @@ pub const Type = struct {
         /// Branching types
         either: []const EitherEntry,
 
-        // TODO: Unused?
-        array_index,
-
         ip_index: struct {
             node: ?Ast.Node.Index = null,
             /// this stores both the type and the value
@@ -1631,7 +1628,6 @@ pub const TypeWithHandle = struct {
                         hashTypeWithHandle(hasher, e.type_with_handle);
                     }
                 },
-                .array_index => {},
                 .ip_index => |payload| {
                     std.hash.autoHash(hasher, payload.node);
                     std.hash.autoHash(hasher, payload.index);
@@ -1683,7 +1679,6 @@ pub const TypeWithHandle = struct {
                         if (!self.eql(ae.type_with_handle, be.type_with_handle)) return false;
                     }
                 },
-                .array_index => {},
                 .ip_index => |a_payload| {
                     const b_payload = b.type.data.ip_index;
 
@@ -1739,7 +1734,7 @@ pub const TypeWithHandle = struct {
         };
     }
 
-    /// Resolves possible types of a type (single for all except array_index and either)
+    /// Resolves possible types of a type (single for all except either)
     /// Drops duplicates
     pub fn getAllTypesWithHandles(ty: TypeWithHandle, arena: std.mem.Allocator) ![]const TypeWithHandle {
         var all_types = std.ArrayListUnmanaged(TypeWithHandle){};
@@ -2540,7 +2535,6 @@ pub const Declaration = union(enum) {
         node: Ast.Node.Index,
         index: u32,
     },
-    array_index: Ast.TokenIndex,
     switch_payload: Switch,
     label_decl: struct {
         label: Ast.TokenIndex,
@@ -2626,7 +2620,6 @@ pub const DeclWithHandle = struct {
             .error_union_payload => |ep| ep.name,
             .error_union_error => |ep| ep.name,
             .array_payload => |ap| ap.identifier,
-            .array_index => |ai| ai,
             .label_decl => |ld| ld.label,
             .error_token => |et| et,
             .assign_destructure => |payload| {
@@ -2808,10 +2801,6 @@ pub const DeclWithHandle = struct {
                 .Single,
             ),
             .assign_destructure => null, // TODO
-            .array_index => TypeWithHandle{
-                .type = .{ .data = .array_index, .is_type_val = false },
-                .handle = self.handle,
-            },
             .label_decl => |decl| try analyser.resolveTypeOfNodeInternal(.{
                 .node = decl.block,
                 .handle = self.handle,

diff --git a/src/features/completions.zig b/src/features/completions.zig
@@ -440,7 +440,6 @@ fn declToCompletion(context: DeclToCompletionContext, decl_handle: Analyser.Decl
         .error_union_error,
         .array_payload,
         .assign_destructure,
-        .array_index,
         .switch_payload,
         .label_decl,
         => {

diff --git a/src/features/hover.zig b/src/features/hover.zig
@@ -91,7 +91,6 @@ pub fn hoverSymbol(
         .error_union_error,
         .array_payload,
         .assign_destructure,
-        .array_index,
         .switch_payload,
         .label_decl,
         .error_token,

diff --git a/src/features/references.zig b/src/features/references.zig
@@ -227,7 +227,7 @@ pub fn symbolReferences(
         },
         .param_payload => |payload| try builder.collectReferences(curr_handle, payload.func),
         .label_decl => unreachable, // handled separately by labelReferences
-        .array_index, .error_token => {},
+        .error_token => {},
     }
 
     return builder.locations;