-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up Nix flake using zon2nix #1395
Conversation
fixed merge conflicts |
Sorry for the late reply! We don't actually have any maintainers who are Nix users as far as I'm aware so this fell through the cracks. @acristoffers sorry to bug you but you really seem to know your nix - at a glimpse this looks correct, just want to make sure I'm not missing anything; could you leave a review if you have time? :) |
@figsoda did what I wanted to do since the beginning but never got to it because I didn't want to manage the dependency tree myself (which it seem zig is not going to have, it's going to be flat). So thanks @figsoda for the project and for cleaning up the mess of ((((functions)))) I had to use to do it in nix with less manual interference :) |
And no problem pinging me @SuperAuguste :) |
resolved merge conflicts |
No worries |
Actually, I do use NixOS as my operating system but I do not have the necessary expertise to review this PR. |
Unfortunately |
At least 1 approving review is required by reviewers with write access. Well, that's not me 🙃 |
resolved merge conflicts |
This reverts commit 6d7305f.
now updating the nix flake just needs one command (
zon2nix > deps.nix
) and we are no longer relying on the magic that stopped comments from workingcloses #1024
also reverts #1265 and updated the comment, as comments are now allowed