resolve config options in tests through the build system #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move similar lines closer together - remove unnecessary added dependencies - always specify single threadedness
Techatrix
force-pushed
the
techatrix/nix-test
branch
from
6c89961 to
59eff39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously when running tests, the zig path, zig lib path and global cache path where all resolved the same way they would be when running ZLS normally that is by looking in PATH and using known_folders.
This means that as an example the zig version that was used to run
zig buildmay not be same as the zig version used by ZLS in its tests. Instead these config options are now resolved through the build system and supplied as an option module.This achieved my goal of running tests in nix which wasn't possible before.