-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrap number hover in code block #2058
Conversation
551556c
to
c2bfaf1
Compare
vscode assumes all comment text is markdown |
sorry but whats your point? does this make anything worse in vscode or just pointing out its not necessary there? i dont have it installed so i cant test. |
i was affirming that this not working in zed is a bug on their part |
zed-industries/zed#5386 upstream issue fwiw |
The downside of this change is that it prevents the table from being shown in "rendered" form if the editor supports Markdown tables (like VS Code). BeforeAfterI would suggest to use the clientInfo to check whether the client/editor is Zed and only in that case apply these changes. make sure to link the upstream issue in the code so that the workaround can be removed once its fixed. |
c2bfaf1
to
690fd13
Compare
sorry for the delay, you commented just after i ran |
690fd13
to
8f7bbb1
Compare
8f7bbb1
to
9147f0a
Compare
I fell your pain. I too had my fun compiling all those crates. |
without this zed would put everything on 1 line, arguably this is probably something they should fix but the
md
also gives the numbers highlighting 🤷♂️. didnt notice this make anything worse on nvim or helix