Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap number hover in code block #2058

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

xdBronch
Copy link
Contributor

without this zed would put everything on 1 line, arguably this is probably something they should fix but the md also gives the numbers highlighting 🤷‍♂️. didnt notice this make anything worse on nvim or helix
image

image

@nektro
Copy link
Contributor

nektro commented Oct 25, 2024

vscode assumes all comment text is markdown

@xdBronch
Copy link
Contributor Author

sorry but whats your point? does this make anything worse in vscode or just pointing out its not necessary there? i dont have it installed so i cant test.

@nektro
Copy link
Contributor

nektro commented Oct 25, 2024

i was affirming that this not working in zed is a bug on their part

@xdBronch
Copy link
Contributor Author

zed-industries/zed#5386 upstream issue fwiw

@Techatrix
Copy link
Member

The downside of this change is that it prevents the table from being shown in "rendered" form if the editor supports Markdown tables (like VS Code).

Before

Screenshot from 2024-11-21 10-36-29

After

Screenshot from 2024-11-21 10-36-16

I would suggest to use the clientInfo to check whether the client/editor is Zed and only in that case apply these changes. make sure to link the upstream issue in the code so that the workaround can be removed once its fixed.

@xdBronch
Copy link
Contributor Author

sorry for the delay, you commented just after i ran cargo clean on zed and i was putting off rebuilding since the dependency tree is like 1300 crates lol

@Techatrix
Copy link
Member

sorry for the delay, you commented just after i ran cargo clean on zed and i was putting off rebuilding since the dependency tree is like 1300 crates lol

I fell your pain. I too had my fun compiling all those crates.

@Techatrix Techatrix merged commit 2eb3a2f into zigtools:master Nov 23, 2024
6 checks passed
@xdBronch xdBronch deleted the push-purwylnonnur branch November 23, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants