Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ngram preprocessing in data_utils #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomwolf
Copy link

@thomwolf thomwolf commented Jun 27, 2019

This is the clean version of #16.

I won't touch this fork so you can merge it when you want.

Copy link

@xueyouluo xueyouluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think simply set beg to end will cause num_predict != goal_num_predict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants