Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid installing Redis library if it's not used #574

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Avoid installing Redis library if it's not used #574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions gptcache/manager/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from gptcache.manager import CacheBase, VectorBase, ObjectBase
from gptcache.manager.data_manager import SSDataManager, MapDataManager
from gptcache.manager.eviction import EvictionBase
from gptcache.manager.scalar_data.redis_storage import RedisCacheStorage
from gptcache.utils.log import gptcache_log


Expand Down Expand Up @@ -107,7 +106,7 @@ def manager_factory(manager="map",
if eviction_params is None:
eviction_params = {}

if isinstance(s, RedisCacheStorage) and eviction_manager == "redis":
if scalar == "redis" and eviction_manager == "redis":
# if cache manager and eviction manager are both redis, we use no op redis to avoid redundant operations
eviction_manager = "no_op_eviction"
gptcache_log.info("Since Scalar Storage and Eviction manager are both redis, "
Expand Down
Loading