Skip to content

Commit

Permalink
Update kafka.go to fix typo and update config for external Kafka Conn…
Browse files Browse the repository at this point in the history
…ection in SASL mode (#72)

* Update kafka.go

Signed-off-by: SahilDevgon <[email protected]>

* Update kafka.go | remove comment

Signed-off-by: SahilDevgon <[email protected]>

* pkg/kafka.go:46 Code is expecting SecurityProtocol in config, fixing same in document

Signed-off-by: SahilDevgon <[email protected]>

* Resolve issue with case-sensitivity

Signed-off-by: Sahil Devgon <[email protected]>

---------

Signed-off-by: SahilDevgon <[email protected]>
Signed-off-by: Sahil Devgon <[email protected]>
  • Loading branch information
devartistgon authored Jan 29, 2024
1 parent 5793bb9 commit 5af6827
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/administration/manage-dependencies/message-storage.md
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,8 @@ metadata:
spec:
config:
kafka:
# securityPolicy supports: PLAINTEXT, SSL, SASL_PLAINTEXT, SASL_SSL
securityPolicy: PLAINTEXT
# securityProtocol supports: PLAINTEXT, SSL, SASL_PLAINTEXT, SASL_SSL
securityProtocol: PLAINTEXT
# saslMechanisms supports: PLAIN, SCRAM-SHA-256, SCRAM-SHA-512
saslMechanisms: PLAIN
saslUsername: ""
Expand Down
2 changes: 1 addition & 1 deletion pkg/external/kafka.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func CheckKafka(conf CheckKafkaConfig) error {
ctx, cancel := context.WithTimeout(context.Background(), DependencyCheckTimeout)
defer cancel()
err := r.SetOffsetAt(ctx, time.Now())
return errors.Wrap(err, "check consume offset from borker failed")
return errors.Wrap(err, "check consume offset from broker failed")
}
return util.DoWithBackoff("checkKafka", checkKafka, util.DefaultMaxRetry, util.DefaultBackOffInterval)
}

0 comments on commit 5af6827

Please sign in to comment.